dgb: pin NodeP2P handshake constants to DigiByte Core (70019 / port 12024) - #252
Merged
Conversation
…2024)
Reconcile the two P2P-handshake constants p2p_node.hpp carried verbatim
from the BTC module against DigiByte Core source (../digibyte):
- protocol_version 70016 -> 70019 (src/version.h PROTOCOL_VERSION).
WTXID_RELAY_VERSION is 70018 < 70019, so BIP 339 wtxidrelay stays
active; advertising the BTC 70016 understated our version to a DGB
peer.
- advertised addr_from port 8333 -> 12024 (kernel/chainparams.cpp:178,
DGB mainnet; testnet 12026 / regtest 18444). The real connect target
is still supplied by run_node via NetService.
Resolves the M3 [decision-needed] TODO. P2P-layer only, no consensus
value; fenced to src/impl/dgb. Producer NodeP2P construct+connect in
run_node is the follow-on slice (gated on a reachable digibyted).
Third BTC-leftover in the embedded coin-daemon version handshake, same class as the proto/port constants this PR already pinned: connected() advertised subversion "c2pool-btc" to digibyted. A DGB embedded node must identify as c2pool-dgb. P2P-layer only, no consensus value; fenced to src/impl/dgb. Verified against live regtest digibyted (DigiByte:8.26.2, getnetworkinfo protocolversion=70019 — matches the proto pin).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase B NodeP2P-producer prep. Reconcile the two P2P-handshake constants
coin/p2p_node.hppcarried verbatim from the BTC module against DigiByte Core source.src/version.hPROTOCOL_VERSION). WTXID_RELAY_VERSION=70018 < 70019, so BIP 339 wtxidrelay stays active. Advertising BTC 70016 understated our version to a DGB peer.kernel/chainparams.cpp:178, mainnet; testnet 12026 / regtest 18444). Real connect target still supplied byrun_nodevia NetService.Resolves the M3
[decision-needed]TODO in p2p_node.hpp. P2P-layer only, no consensus value; fenced tosrc/impl/dgb, no shared-base / other-coin touch. Build EXIT=0, --selftest OK.NOTE: integrators 06-20 directive suggested pinning 70016; the source-of-truth DGB Core value is 70019 (verified ../digibyte). Producer
NodeP2Pconstruct+connect in run_node is the follow-on slice, gated on a reachable digibyted (DGB Core build kicked).